Review process

4
open
ltmylinh
ltmylinh
Posted 2 years ago

Review process #5

This issue is created to discuss about review process:

  • How many approvals do we need for a PR?
  • Who will take responsibility to merge PR?
nampdn
nampdn
Created 2 years ago
  • To make the review process solid, I think we should have at least 1 approval.

  • At this time, we are only 2 maintainers, I think both of us can merge if a PR is approved.

ltmylinh
ltmylinh
Created 2 years ago

I prefer at least 2 approvals. More reviewers will have good quality. We have @anhphamduy in our team, right?

Quynh-Nguyen
Quynh-Nguyen
Created 2 years ago

@nampdn @ltmylinh Hi bros, Can I join this project? I will help translate at night.

huyqdang
huyqdang
Created 2 years ago

Yo yo, I want to help as well.