WalterNorthwoods

WalterNorthwoods

Member Since 6 years ago

@NorthwoodsSoftware , Nashua NH USA UTC-05:00

Experience Points
12
follower
Lessons Completed
0
follow
Lessons Completed
2
stars
Best Reply Awards
0
repos

48 contributions in the last year

Pinned
Activity
Jan
14
5 days ago
Activity icon
issue

WalterNorthwoods issue comment NorthwoodsSoftware/GoJS

WalterNorthwoods
WalterNorthwoods

Animation while editing a TextBlock cause weird behavior

Hello, I came across a strange behavior that happens when you edit a text in a TextBlock, and at the same time animate the diagram/node. The text editing window stays in the previous place, and it looks very strange ...

A reproducible link: https://codepen.io/ba2sik/pen/MWEVrYb Simply click twice on the node to edit the text, and watch editing winow.

WalterNorthwoods
WalterNorthwoods

That would be very disconcerting to most users.

Activity icon
issue

WalterNorthwoods issue comment NorthwoodsSoftware/GoJS

WalterNorthwoods
WalterNorthwoods

Animation not working when collapsing subgraph

Hello, If you look at this demo, when clicking + on Main1, the border/stroke around the items in the group, and the group header, is growing with animation, but when collapsing when clicking -, the stroke around the items and the header simply disappears, without doing it with animation.

Is it possible to override the closing animation somehow to make it work?

Thank you

WalterNorthwoods
WalterNorthwoods

Yes, that does appear to be inconsistent. However, that is how it was designed. I suppose an implementation alternative could be achieved by customizing the group's border computation to include not-visible member nodes during animation.

Activity icon
issue

WalterNorthwoods issue comment NorthwoodsSoftware/GoJS

WalterNorthwoods
WalterNorthwoods

Animation while editing a TextBlock cause weird behavior

Hello, I came across a strange behavior that happens when you edit a text in a TextBlock, and at the same time animate the diagram/node. The text editing window stays in the previous place, and it looks very strange ...

A reproducible link: https://codepen.io/ba2sik/pen/MWEVrYb Simply click twice on the node to edit the text, and watch editing winow.

WalterNorthwoods
WalterNorthwoods

For v2.2, upon activation the TextEditingTool now stops any default animation.

Activity icon
issue

WalterNorthwoods issue NorthwoodsSoftware/GoJS

WalterNorthwoods
WalterNorthwoods

Animation not working when collapsing subgraph

Hello, If you look at this demo, when clicking + on Main1, the border/stroke around the items in the group, and the group header, is growing with animation, but when collapsing when clicking -, the stroke around the items and the header simply disappears, without doing it with animation.

Is it possible to override the closing animation somehow to make it work?

Thank you

Activity icon
issue

WalterNorthwoods issue comment NorthwoodsSoftware/GoJS

WalterNorthwoods
WalterNorthwoods

Animation not working when collapsing subgraph

Hello, If you look at this demo, when clicking + on Main1, the border/stroke around the items in the group, and the group header, is growing with animation, but when collapsing when clicking -, the stroke around the items and the header simply disappears, without doing it with animation.

Is it possible to override the closing animation somehow to make it work?

Thank you

WalterNorthwoods
WalterNorthwoods

Not easily. It might be possible to turn off that built-in animation and implement everything yourself.

This is not a bug in the library or samples or documentation, so this topic does not belong here.

Jan
7
1 week ago
Activity icon
issue

WalterNorthwoods issue comment NorthwoodsSoftware/gojs-angular

WalterNorthwoods
WalterNorthwoods

(modelChange) not being triggered when the link object is custom and `data` prop modified

Hi,

I'm not exactly positive if this is a bug or not but it's a scenario I've encountered in one of my usages of the library.

The (modelChange) Angular output on the <gojs-diagram> component, does not trigger whenever i specifically try modifying the data property of a specific link. I am including a code sample below for further clarification.

Note: My gut feeling tells me I'm somehow doing this wrong but on other node properties, using the setProperties(...) works perfectly fine, while on link properties the setProperties(...) is only working for 'original' (non-custom) link properties.

Example: (please note example has been simplified on-purpose HTML:

    <gojs-diagram
      #myDiagram
      (modelChange)='diagramModelChange($event)'
      [initDiagram]='initDiagram'
      [linkDataArray]='state.diagramLinkData'
      [nodeDataArray]='state.diagramNodeData'
      [skipsDiagramUpdate]='state.skipsDiagramUpdate'
      divClassName='myDiagramDiv'
    >
    </gojs-diagram>

TS:

...

state = {
  diagramNodeData: [
    {
      id: 1,
      text: 'Alpha',
    },
    {
      id: 2,
      text: 'Beta',
    },
  ],
  diagramLinkData: [
    {
      key: 1,
      from: 1,
      to: 2,
      text: 'transition',
      customLabel: 'myCustomLabel' // <--- This is my issue (custom property)
    },
  ],
}

...

Then in the initDiagram() function where I declare my link template I am binding the customLabel text as follows:

...
      $$(
        go.TextBlock, new go.Binding('text', 'customLabel'),
      ),
...

My main issue/question here is: how do I update the customLabel text dynamically/programmatically?

I've tried using the below approach but even though the text update happens successfully, whenever I use the below code and update the data property below, from that point onwards the (modelChange) output stops triggering for any links that get deleted, whilst for nodes updates it still works ok.

      // once the below code executes, I stop receiving updates on the `modelChange` for any links (e.g. link deletion, etc...)
      this.myDiagramComponent.diagram
        .findLinkForKey(1) // using ID 1 for example
        .setProperties({
          data: {
            customLabel: 'newCustomLabelValue'
          }
        });

I'm concerned that I'm doing the above, last part wrong here, but I couldn't find any other way of how to update 'custom labels' dynamically on links and couldn't find any examples in the docs.

Thanks!

WalterNorthwoods
WalterNorthwoods

About calling GraphObject.setProperties:

Normally one should not call this at run-time, because it is inefficient. But you are just modifying one link, and you are using Angular anyway, so that's not a problem. https://gojs.net/latest/api/symbols/GraphObject.html#setProperties

But the real issue is that you are setting Panel.data, which is normally reserved to the internal code that copies templates and manages bindings and all that. https://gojs.net/latest/api/symbols/Panel.html#data

Jan
2
2 weeks ago
Activity icon
issue

WalterNorthwoods issue comment NorthwoodsSoftware/GoJS

WalterNorthwoods
WalterNorthwoods

Animation while editing a TextBlock cause weird behavior

Hello, I came across a strange behavior that happens when you edit a text in a TextBlock, and at the same time animate the diagram/node. The text editing window stays in the previous place, and it looks very strange ...

A reproducible link: https://codepen.io/ba2sik/pen/MWEVrYb Simply click twice on the node to edit the text, and watch editing winow.

WalterNorthwoods
WalterNorthwoods

Either:

  • do not select the node, or
  • only start editing after the animation is done, or
  • stop any animation before starting editing
Dec
17
1 month ago
Activity icon
issue

WalterNorthwoods issue comment NorthwoodsSoftware/GoJS

WalterNorthwoods
WalterNorthwoods

Images do not render in call to makeSvg or makeImage (Angular)

Hello,

makeSvg or makeImage not serving pictures ,

the bug related to uppercase letters in the URL,

ref source: https://forum.nwoods.com/t/images-do-not-render-in-call-to-makesvg-or-makeimage/11669/32

WalterNorthwoods
WalterNorthwoods

Domain names are case insensitive. URIs or URLs are generally case-sensitive.

Activity icon
issue

WalterNorthwoods issue NorthwoodsSoftware/GoJS

WalterNorthwoods
WalterNorthwoods

Images do not render in call to makeSvg or makeImage (Angular)

Hello,

makeSvg or makeImage not serving pictures ,

the bug related to uppercase letters in the URL,

ref source: https://forum.nwoods.com/t/images-do-not-render-in-call-to-makesvg-or-makeimage/11669/32

Dec
15
1 month ago
Activity icon
created tag
createdAt 1 month ago
Dec
14
1 month ago
Nov
23
1 month ago
Activity icon
created tag
createdAt 1 month ago
Activity icon
published release 2.1.54

WalterNorthwoods in NorthwoodsSoftware/GoJS create published release 2.1.54

createdAt 1 month ago
push

WalterNorthwoods push NorthwoodsSoftware/GoJS

WalterNorthwoods
WalterNorthwoods

2.1.54

Changes for 2.1.54

  • Fixed Diagram.viewSize when setting it to a real value and then later setting it back to a NaN value.
  • As with 2.1.52, fixed more scenarios with custom animations improperly adding state to the AnimationManager.defaultAnimation.
  • Fixed rare cases of LayeredDigraphLayout trying to get the "centerX" property of a null vertex.

commit sha: 91136c2ee971725c66b6a4990d6e2aca5ffc2c97

push time in 1 month ago
Nov
22
1 month ago
Activity icon
issue

WalterNorthwoods issue comment NorthwoodsSoftware/GoJS

WalterNorthwoods
WalterNorthwoods

Cannot read properties of null (reading 'centerX')

Hello, I have this data

[{ key: "1", n: "1", s: "M"   ,  ux:"2"   },
{ key: "2", n: "2", s: "F"    ,  vir:"1"   },
{ key: "8", n: "8", s: "F"  ,  vir:"17" , m: "2" , f: "1"},
{ key: "17", n: "17", s: "M"  ,  ux:"8"    }]

and Im getting error here

image

because id 17 was not created.

image

I use code from your example https://github.com/NorthwoodsSoftware/GoJS/blob/master/samples/genogram.html

Can you please help to fix it?

Problem is in { key: "8", n: "8", s: "F" , vir:"17" , m: "2" , f: "1"},

Because it works with { key: "8", n: "8", s: "F" , vir:"17" },

also it works if I change ID to int. But with full data

[{ key: 1, n: "1", s: "M"   ,  ux:[2,12,90,160]   },
{ key: 2, n: "2", s: "F"    ,  vir:1  },
{ key: 8, n: "8", s: "F" , m: 2 , f: 1  ,  vir:17  },
{ key: 12, n: "12", s: "F"    ,  vir:[1,19,109,164]  },
{ key: 13, n: "13", s: "F" , m: 12 , f: 1  ,  vir:[19,63,72,101,109,163]  },
{ key: 15, n: "15", s: "F" , m: 12 , f: 1  ,  vir:[19,166]  },
{ key: 17, n: "17", s: "M"   ,  ux:8   },
{ key: 19, n: "19", s: "M" , m: 8 , f: 17 ,  ux:[12,13,15,35,76,88,116]   },
{ key: 27, n: "27", s: "M" , m: 8 , f: 17 ,  ux:32   },
{ key: 32, n: "32", s: "F" , m: 13 , f: 19  ,  vir:27  },
{ key: 35, n: "35", s: "F" , m: 15 , f: 19  ,  vir:[19,63,101,163]  },
{ key: 63, n: "63", s: "M"   ,  ux:[13,35]   },
{ key: 72, n: "72", s: "M"   ,  ux:13   },
{ key: 76, n: "76", s: "F" , m: 13 , f: 72  ,  vir:[19,101]  },
{ key: 88, n: "88", s: "F"    ,  vir:[19,101]  },
{ key: 90, n: "90", s: "F" , m: 88 , f: 19  ,  vir:[1,101]  },
{ key: 101, n: "101", s: "M"   ,  ux:[13,35,76,88,90]   },
{ key: 109, n: "109", s: "M"   ,  ux:[12,13]   },
{ key: 111, n: "111", s: "F" , m: 13 , f: 109  ,  vir:117  },
{ key: 116, n: "116", s: "F" , m: 88 , f: 101  ,  vir:[19,164]  },
{ key: 117, n: "117", s: "M" , m: 88 , f: 101 ,  ux:111   },
{ key: 153, n: "153", s: "F" , m: 90 , f: 1  ,  vir:164  },
{ key: 160, n: "160", s: "F" , m: 88 , f: 101  ,  vir:1  },
{ key: 163, n: "163", s: "M" , m: 88 , f: 101 ,  ux:[13,35]   },
{ key: 164, n: "164", s: "M"   ,  ux:[12,116,153,223]   },
{ key: 166, n: "166", s: "M" , m: 116 , f: 164 ,  ux:15   },
{ key: 223, n: "223", s: "F"    ,  vir:164  }]

Im gettig error Cannot read properties of null (reading 'centerX')

image

http://jsfiddle.net/Risay/ehcyvp50/

WalterNorthwoods
WalterNorthwoods

Thanks for providing a reproducible case. The bug fix will be in version 2.1.54, which should be coming out pretty soon.

Activity icon
issue

WalterNorthwoods issue NorthwoodsSoftware/GoJS

WalterNorthwoods
WalterNorthwoods

Cannot read properties of null (reading 'centerX')

Hello, I have this data

[{ key: "1", n: "1", s: "M"   ,  ux:"2"   },
{ key: "2", n: "2", s: "F"    ,  vir:"1"   },
{ key: "8", n: "8", s: "F"  ,  vir:"17" , m: "2" , f: "1"},
{ key: "17", n: "17", s: "M"  ,  ux:"8"    }]

and Im getting error here

image

because id 17 was not created.

image

I use code from your example https://github.com/NorthwoodsSoftware/GoJS/blob/master/samples/genogram.html

Can you please help to fix it?

Problem is in { key: "8", n: "8", s: "F" , vir:"17" , m: "2" , f: "1"},

Because it works with { key: "8", n: "8", s: "F" , vir:"17" },

also it works if I change ID to int. But with full data

[{ key: 1, n: "1", s: "M"   ,  ux:[2,12,90,160]   },
{ key: 2, n: "2", s: "F"    ,  vir:1  },
{ key: 8, n: "8", s: "F" , m: 2 , f: 1  ,  vir:17  },
{ key: 12, n: "12", s: "F"    ,  vir:[1,19,109,164]  },
{ key: 13, n: "13", s: "F" , m: 12 , f: 1  ,  vir:[19,63,72,101,109,163]  },
{ key: 15, n: "15", s: "F" , m: 12 , f: 1  ,  vir:[19,166]  },
{ key: 17, n: "17", s: "M"   ,  ux:8   },
{ key: 19, n: "19", s: "M" , m: 8 , f: 17 ,  ux:[12,13,15,35,76,88,116]   },
{ key: 27, n: "27", s: "M" , m: 8 , f: 17 ,  ux:32   },
{ key: 32, n: "32", s: "F" , m: 13 , f: 19  ,  vir:27  },
{ key: 35, n: "35", s: "F" , m: 15 , f: 19  ,  vir:[19,63,101,163]  },
{ key: 63, n: "63", s: "M"   ,  ux:[13,35]   },
{ key: 72, n: "72", s: "M"   ,  ux:13   },
{ key: 76, n: "76", s: "F" , m: 13 , f: 72  ,  vir:[19,101]  },
{ key: 88, n: "88", s: "F"    ,  vir:[19,101]  },
{ key: 90, n: "90", s: "F" , m: 88 , f: 19  ,  vir:[1,101]  },
{ key: 101, n: "101", s: "M"   ,  ux:[13,35,76,88,90]   },
{ key: 109, n: "109", s: "M"   ,  ux:[12,13]   },
{ key: 111, n: "111", s: "F" , m: 13 , f: 109  ,  vir:117  },
{ key: 116, n: "116", s: "F" , m: 88 , f: 101  ,  vir:[19,164]  },
{ key: 117, n: "117", s: "M" , m: 88 , f: 101 ,  ux:111   },
{ key: 153, n: "153", s: "F" , m: 90 , f: 1  ,  vir:164  },
{ key: 160, n: "160", s: "F" , m: 88 , f: 101  ,  vir:1  },
{ key: 163, n: "163", s: "M" , m: 88 , f: 101 ,  ux:[13,35]   },
{ key: 164, n: "164", s: "M"   ,  ux:[12,116,153,223]   },
{ key: 166, n: "166", s: "M" , m: 116 , f: 164 ,  ux:15   },
{ key: 223, n: "223", s: "F"    ,  vir:164  }]

Im gettig error Cannot read properties of null (reading 'centerX')

image

http://jsfiddle.net/Risay/ehcyvp50/

Nov
5
2 months ago
Activity icon
published release 2.1.53

WalterNorthwoods in NorthwoodsSoftware/GoJS create published release 2.1.53

createdAt 2 months ago
Activity icon
created tag
createdAt 2 months ago
push

WalterNorthwoods push NorthwoodsSoftware/GoJS

WalterNorthwoods
WalterNorthwoods

2.1.53

  • Fixed Binding.ofModel binding when there is no Diagram and thus no Model to just ignore the binding.
  • Fixed a regression in Diagram.makeSVG from 2.1.49 when using a Panel.Spot with Panel.isClipping set to true, where some elements would get grouped and positioned incorrectly.
  • Fixed Model.toJSON output when object keys contained unescaped double-quote characters.
  • Fixed some Shape Geometry intersections (such as with Link connections) when the Shape's Geometry contained small and flat beziers.
  • Fixed collapsed Parts incorrectly causing their Groups to remeasure, which may have caused Group's connected Links to re-route.

commit sha: 7af4c3d0d7b4b328e3d6adc6d50044197624df4f

push time in 2 months ago
Oct
19
3 months ago
Activity icon
issue

WalterNorthwoods issue NorthwoodsSoftware/GoJS

WalterNorthwoods
WalterNorthwoods

DimensioningLink extension not binding points

Hi,

I found a bug in the DimensioningLink extension, when you use it with binding points to save the current position after (reshapable edits ),

$(DimensioningLink,{reshapable: true,resegmentable:true}, new go.Binding("fromSpot", "fromSpot", go.Spot.parse), new go.Binding("toSpot", "toSpot", go.Spot.parse), new go.Binding("direction"), new go.Binding("extension"), new go.Binding("inset"), now if I remove or add a new link with ( committing transitions ), I lose the positions of links

Activity icon
issue

WalterNorthwoods issue comment NorthwoodsSoftware/GoJS

WalterNorthwoods
WalterNorthwoods

DimensioningLink extension not binding points

Hi,

I found a bug in the DimensioningLink extension, when you use it with binding points to save the current position after (reshapable edits ),

$(DimensioningLink,{reshapable: true,resegmentable:true}, new go.Binding("fromSpot", "fromSpot", go.Spot.parse), new go.Binding("toSpot", "toSpot", go.Spot.parse), new go.Binding("direction"), new go.Binding("extension"), new go.Binding("inset"), now if I remove or add a new link with ( committing transitions ), I lose the positions of links

WalterNorthwoods
WalterNorthwoods

That seems to be a bug in the DimensioningLink extension. Try removing the call to updateTargetBindings() in the computePoints method. I don't know why that call is there.